From 1145a13bc0a00718d66ecccc62affb03ba449e3e Mon Sep 17 00:00:00 2001 From: Gaston Gonzalez Date: Thu, 31 Oct 2024 08:15:45 -0700 Subject: [PATCH] Bug - Fixed an issue where continuous polling of rigctld to obtain the VFO causes momentary frequency switches on some Icom radios. This has undefined behavior that impacts both receive and transmit operations when clients like Conky call into the et-system-info command. A more robust client will be created when the EmComm Tools GUI application is introduced. --- overlay/opt/emcomm-tools/bin/et-system-info | 23 ++++++++++++++------- 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/overlay/opt/emcomm-tools/bin/et-system-info b/overlay/opt/emcomm-tools/bin/et-system-info index fcc9879..8dc6702 100755 --- a/overlay/opt/emcomm-tools/bin/et-system-info +++ b/overlay/opt/emcomm-tools/bin/et-system-info @@ -2,7 +2,7 @@ # # Author : Gaston Gonzalez # Date : 6 October 2024 -# Updated : 25 October 2024 +# Updated : 30 October 2024 # Purpose : Utility script for dumping system information function usage() { @@ -102,14 +102,21 @@ case $1 in # 2. Check if the rigctl systemd unit is running properly systemctl status rigctld --no-pager > /dev/null if [ $? -eq 0 ]; then - + + # Note: I am disabling the VFO read as it causes issues with serval Icom + # radios and results in the VFO changing momentarily during this client + # request. It causes issues during TX and RX. If it is not bulletproof, + # features like this will be turned off. This is a problem given that + # Conky calls this method every 10 seconds. + # # 3. Grab and format frequency - FREQ=$(timeout 1 rigctl -m 2 f) - if [ $? -eq 0 ]; then - printf "%'d MHz\n" "$FREQ" | sed 's|,|.|g' - else - echo "Connected. Can't access VFO"; - fi + #FREQ=$(timeout 1 rigctl -m 2 f) + #if [ $? -eq 0 ]; then + # printf "%'d MHz\n" "$FREQ" | sed 's|,|.|g' + #else + # echo "Connected. Can't access VFO"; + #fi + echo "Connected"; else echo "Connected. No rig control" fi